Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

still fails on windows (AppVeyor) #18

Closed
tunnckoCore opened this issue Dec 11, 2016 · 4 comments
Closed

still fails on windows (AppVeyor) #18

tunnckoCore opened this issue Dec 11, 2016 · 4 comments

Comments

@tunnckoCore
Copy link
Contributor

While updating https://github.com/tunnckoCore/detect-installed i get red in AppVeyor.

Started debugging with console.log-ing the joined filepath and the path that comes from global-modules (so global-prefix). tunnckoCore/detect-installed#8

If this helps https://ci.appveyor.com/project/tunnckoCore/detect-installed/build/1.0.13 ...
Or in short: that's C:\Users\appveyor\AppData\Roaming\npm\node_modules the path that global-modules returns. Don't know if it is correct.

@doowb
Copy link
Collaborator

doowb commented Dec 11, 2016

https://www.appveyor.com/docs/lang/nodejs-iojs/#how-that-works

That page has information that indicates that's where the global node_modules folder is on appveyor. I see that you have tests in detect-installed that look to see if npm is installed. It looks like appveyor doesn't explicitly npm i npm -g so the npm used is under the nodejs/node_modules folder instead of the global npm/ node_modules folder.

I would add a build step in your .appveyor.yml that explicitly installs npm (or some other global module) then test for that to ensure it's correct.

@jonschlinkert
Copy link
Owner

@doowb that's great info for the readme here. I can add next time I get a chance, or if you or @tunnckoCore wants to that would be great too

@tunnckoCore
Copy link
Contributor Author

@doowb super, I'll try it and will send a PR if it works. Thanks.

@tunnckoCore
Copy link
Contributor Author

Great, it worked for me. Thanks again @doowb.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants