Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dot directory and {* /} combination is not working #38

Closed
masakura opened this issue Aug 4, 2015 · 6 comments
Closed

Dot directory and {* /} combination is not working #38

masakura opened this issue Aug 4, 2015 · 6 comments
Labels

Comments

@masakura
Copy link

masakura commented Aug 4, 2015

Dot directory and {* /} combination is not working

Start dot directory, failed.

> mm.isMatch('.a/xyz.md', '.a/{,*/}xyz.md')
false
> mm.isMatch('.a/xyz.md', '.a/**/xyz.md')
false

Start not dot directory, success.

> mm.isMatch('a/xyz.md', 'a/{,*/}xyz.md')
true
> mm.isMatch('a/xyz.md', 'a/**/xyz.md')
true
@jonschlinkert
Copy link
Member

thanks for reporting, marking as a bug

@tconroy
Copy link

tconroy commented Aug 19, 2015

Status on this issue?

@jonschlinkert
Copy link
Member

I'm working on the next version of this and got sidetracked and forgot to come back to this. sorry I'll try to take a look today.

@tconroy
Copy link

tconroy commented Aug 19, 2015

No worries, thank you for your hard work :)

jonschlinkert added a commit to micromatch/braces that referenced this issue Aug 21, 2015
jonschlinkert added a commit that referenced this issue Aug 21, 2015
jonschlinkert added a commit that referenced this issue Aug 21, 2015
jonschlinkert added a commit that referenced this issue Aug 21, 2015
jonschlinkert added a commit that referenced this issue Aug 21, 2015
jonschlinkert added a commit that referenced this issue Aug 21, 2015
@callumlocke
Copy link

I see a bunch of commits... Can this be closed now?

@jonschlinkert
Copy link
Member

I think I just need to publish 0.2.3. sorry for the delay, it's on my priority list for today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants