Improved filter performance #44
Conversation
|
9 tests don't pass on windows in master. |
with these changes or before? |
|
@jonschlinkert Both |
|
What version of windows/node are you using? I typically run the tests and bechmarks on both windows and mac. |
|
@jonschlinkert windows 7 && node 0.12 && npm 3 |
|
Thanks for the additional info! I'll take a look at this asap. just wanted you to know I didn't forget |
|
Thanks, Jon |
| @@ -150,7 +155,7 @@ function filter(patterns, opts) { | |||
|
|
|||
| fp = utils.unixify(fp, opts); | |||
| while (i < len) { | |||
| var fn = matcher(patterns[i++], opts); | |||
| var fn = patterns[i++]; | |||
| if (!fn(fp)) { | |||
| res = false; | |||
There was a problem hiding this comment.
These are great changes. nice work.
@es128 any objections to merging? I was going to do a 2.4.0 patch release with housekeeping stuff, like changing to eslint, but maybe we just merge this and do 2.4.0. then I can follow up with a 2.5.0. sound ok?
There was a problem hiding this comment.
No substantial objections to the change, but if there's no change to API footprint why not bump patch instead of minor?
Also would still like to see tests added for the backslash scenarios, and generally it's safer to run anymatch and chokidar tests on any patch before release just in case.
There was a problem hiding this comment.
Nevermind my comment about the backslash tests, just noticed you already did that. 👍
There was a problem hiding this comment.
why not bump patch instead of minor?
of course lol, I was pretty tired when I wrote that. seems I was looking for the most complicated way to do things possible lol
|
Tests passing now. LGTM |
|
Squash it? |
|
Up to @jonschlinkert... I don't think it's needed in this case, personally. |
|
all is good, thanks! |
Improved filter performance
Reduced matchers computing