Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes end time when changing date #128

Closed
espen opened this issue Jan 10, 2021 · 3 comments
Closed

Changes end time when changing date #128

espen opened this issue Jan 10, 2021 · 3 comments

Comments

@espen
Copy link

espen commented Jan 10, 2021

How to reproduce:

  1. Go to basic example at https://www.jonthornton.com/Datepair.js/

  2. Set start date to current date.

  3. Set time to 2:00am.

  4. Set end time to 5:00am.

  5. Change start date to yesterday. End date is changed to yesterday (as expected). End time is now changed from 5:00am to 3:00am.

Changing the date further does not change the end time.

@espen
Copy link
Author

espen commented Jan 10, 2021

After some investigation it seems like this is an issue in https://github.com/jonthornton/jquery-timepicker/

I'm unable to replicate the issue when using jquery.timepicker 1.13.14. With any newer version I get the outcome in this issue.

@jonthornton
Copy link
Owner

@espen you're correct, there was an event bubbling bug in jquery.timepicker jonthornton/jquery-timepicker@0873fe4

It should be fixed now.

@espen
Copy link
Author

espen commented Feb 14, 2021

New version works perfectly. Thanks @jonthornton 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants