Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disableTouchKeyboard can prevent focus on non-touch devices #413

Closed
scurker opened this issue Jul 29, 2015 · 1 comment
Closed

disableTouchKeyboard can prevent focus on non-touch devices #413

scurker opened this issue Jul 29, 2015 · 1 comment

Comments

@scurker
Copy link

scurker commented Jul 29, 2015

Currently, the check being performed is 'ontouchstart' in document, but this doesn't actually check for the existence of a touch device but rather or not the browser has touch events enabled. There's a pretty good discussion on modernizr.

There can be instances where Firefox or Chrome have touch events enabled (such as on Surface tablets) and may or may not actually be a touch device. In the case of jQuery timepicker, this prevents timepicker input field from being focused in some cases where touchevents are enabled but the device isn't actually a touch device.

There doesn't appear to be a good way to detect whether or not the device actually does support touch, so I feel the documentation should be updated at the very least to reflect the caveats of setting disableTouchKeyboard.

@jonthornton
Copy link
Owner

Thank you for pointing this out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants