Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jstachio/rocker: remove buffer reuse from RockerModule/JStachioModule #3424

Closed
jknack opened this issue May 14, 2024 · 1 comment
Closed

jstachio/rocker: remove buffer reuse from RockerModule/JStachioModule #3424

jknack opened this issue May 14, 2024 · 1 comment
Labels
bug rocker
Milestone
3.1.1

Comments

@jknack
Copy link
Member

jknack commented May 14, 2024

Not need it with the new buffer API. It causes a netty leak bc of the custom ThreadLocal cache that uses.
@jknack jknack added this to the 3.1.1 milestone May 14, 2024
@agentgt
Copy link
Contributor

agentgt commented May 15, 2024

Probably need to do this for JStachio as well. I’ll take a look later today.

@jknack jknack changed the title rocker: remove buffer reuse from RockerModule jstachio/rocker: remove buffer reuse from RockerModule/JStachioModule May 19, 2024
@jknack jknack closed this as completed in ce92b0b May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug rocker
Projects
None yet
Milestone
3.1.1
Development

No branches or pull requests
2 participants
@agentgt @jknack