New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AndroidComponents API support #3
Conversation
private val isDirtyByDefault: Boolean = false, | ||
) : ClassVisitor(asmApi, classVisitor) { | ||
|
||
var isDirty: Boolean = false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
точно ли должно тут это проперти в public торчать?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
копипастил из colonist, вроде нет причины наружу торчать
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
private const val IS_ENABLED_DEPRECATION_WARNING = "paranoid.enabled is deprecated. Use paranoid.applyToBuildTypes" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
тут можно через ReplaceWith
прописать, чтобы в студии автозамену можно было сделать
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
) | ||
|
||
try { | ||
processor.process() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
может validate()
и cleanOutPut()
тоже под try-catch
затянуть, чтобы в случае всяких IOException-ов было понятно что за таска?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Мне кажется оно и так понятно будет какая таска упала, но обернул
} | ||
var isCacheable: Boolean = false | ||
var includeSubprojects: Boolean = false | ||
var isEnabled: Boolean by deprecatedProperty(true, IS_ENABLED_DEPRECATION_WARNING) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
может тут кастомный getter-setter сделать, чтобы оно applyToBuildTypes
выставляло, тогда можно будет в новом коде уже не использовать isEnabled
и избавиться от @Suppress("DEPRECATION")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
@@ -9,6 +9,7 @@ allprojects { | |||
buildscript { | |||
repositories { | |||
google() | |||
mavenLocal() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
В комментарии к коммиту говориться "Add mavenCentral to repositories..." скорее всего опечатка, и имелось в виду все-таки mavenLocal
, но решил обратить внимание на всякий пожарный
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
…sses processed by paranoid.
… should be processed were indeed processed by paranoid.
…ks up into jar task for java projects.
…at text is displayed.
998c1d5
to
2b46b99
Compare
2b46b99
to
1159eef
Compare
ParanoidPlugin
so it can be applied to java modules as well as android modules.@Obfuscate
annotation.WatermarkClassVisitor
), soParanoidProcessor
can validate paranoid plugin usage by checking whether this attribute is present in should-be-transformed classes available in classpath.ParanoidTransformTask
.