Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support of the JED Submission Error Codes #155

Closed
anibalsanchez opened this issue Sep 4, 2021 · 12 comments · Fixed by #157
Closed

Support of the JED Submission Error Codes #155

anibalsanchez opened this issue Sep 4, 2021 · 12 comments · Fixed by #157
Assignees

Comments

@anibalsanchez
Copy link
Contributor

On the site, there is a general error coding system, the "Submission Error Codes": https://extensions.joomla.org/support/knowledgebase/item/submission-error-codes/

It is a quick way to refer to the error and classify the submission.

In the current UI, there is no easy way to associate the code with the error description.

Please, could you associate each error with a "Submission Error Code".

Thanks in advance.

CC: @dryabov

@Llewellynvdm
Copy link
Collaborator

Just a question, but was it not like this before? and why was this changed?

@anibalsanchez
Copy link
Contributor Author

The JED Team is the main user of these error codes. The developers are not really used to PH1, NM1, LI1 or US.

In the previous UI, the error codes were always in the error description. Most people don't notice them.

error-codes

@dryabov
Copy link
Collaborator

dryabov commented Sep 4, 2021

Most likely it's necessary to expand existing list of error codes to take into account new rules, e.g. "invalid language file", or "file not found" (for XMLFiles ruleset).

@Llewellynvdm
Copy link
Collaborator

Please use this list as the bases, and add those new needed in this issue so we can in the next JED team meeting go over this as a team.

The next team meeting is this coming Friday the 10th of September.

@Llewellynvdm
Copy link
Collaborator

There can be no next release without this being fixed.

@dryabov
Copy link
Collaborator

dryabov commented Sep 6, 2021

What kind of design do you prefer? (you can vote using GitHub's reactions icons)

@dryabov
Copy link
Collaborator

dryabov commented Sep 6, 2021

2021-09-06 22_30_15-JED Checker - J4 0 Test - Administration

@dryabov
Copy link
Collaborator

dryabov commented Sep 6, 2021

2021-09-06 22_32_21-JED Checker - J4 0 Test - Administration

@dryabov
Copy link
Collaborator

dryabov commented Sep 6, 2021

2021-09-06 22_34_18-JED Checker - J4 0 Test - Administration

@JazParkyn
Copy link
Member

JazParkyn commented Sep 7, 2021

2021-09-06 22_30_15-JED Checker - J4 0 Test - Administration

I prefer this option, but with an adjustment in the badge text. Change 'PH1 Error' to 'Error: PH1'. Then also implement the same format for info, warning and success badges too. Eg. 'Info: GPL' or 'Passed: US1'

@anibalsanchez
Copy link
Contributor Author

Jaz recommendations are on the spot. 👍

@dryabov
Copy link
Collaborator

dryabov commented Sep 9, 2021

OK, the patch is added to the PR #157

@Llewellynvdm Llewellynvdm linked a pull request Sep 9, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants