Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Github Credential Authentication now that it's expired in November 2020 #319

Closed
particthistle opened this issue Mar 20, 2021 · 1 comment

Comments

@particthistle
Copy link

Steps to reproduce the issue

While assisting some students with GSoC tonight, Philip Walton and I spotted the alert when Credentials are selected as the GitHub Authentication method.

image

Should the credentials method be removed in the next version of Patch Tester now that it's been deprecated by GitHub?

Documentation on the Patch Tester that I'm aware of so far already refers to using the Token method, so taking it out should not impact users.
https://docs.joomla.org/Testing_Joomla!_patches
https://magazine.joomla.org/all-issues/june-2020/github-installing-git

@particthistle
Copy link
Author

Closing as #320 addresses the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant