Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unnecessary closing div tag #28

Closed
QkiZMR opened this issue Mar 29, 2015 · 4 comments · Fixed by #33
Closed

Unnecessary closing div tag #28

QkiZMR opened this issue Mar 29, 2015 · 4 comments · Fixed by #33

Comments

@QkiZMR
Copy link

QkiZMR commented Mar 29, 2015

Steps to reproduce the issue

Display weblinks component. Unnecessary tag in /components/com_weblinks/views/categories/tmpl/default.php causes mess in template. Line number 17.

Expected result

Correct display of weblinks component. Solution is create weblinks override without closing div tag.

Actual result

Mess in weblinks in custom template.

System information (as much as possible)

Linux, Apache, Mysql

Screenshots from messed webpage and corrected one:
http://image.qkiz.pl/di/UBY5/bad.png
http://image.qkiz.pl/di/TNQP/good.png
@zero-24 zero-24 mentioned this issue Apr 9, 2015
Merged
@zero-24
Copy link
Contributor

zero-24 commented Apr 9, 2015

@QkiZMR please try: #33 Thanks!

@QkiZMR
Copy link
Author

QkiZMR commented Apr 9, 2015

Ok, thx.

@QkiZMR QkiZMR closed this as completed Apr 9, 2015
@zero-24
Copy link
Contributor

zero-24 commented Apr 9, 2015

@QkiZMR are you able to test it? If yes please comment on #33 so we can move it forward and fix it with 3.4.1 of com_weblinks 😄

@QkiZMR
Copy link
Author

QkiZMR commented Apr 9, 2015

Diff files from https://github.com/joomla/joomla-cms/pull/6134/files doesn't match to files from my Joomla ver. 3.4.1 Stable

@w00fz w00fz mentioned this issue May 12, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Backport: [imp] avoid to open div and closing it in different files
2 participants
@zero-24 @QkiZMR