Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email sharing doesn't seem to be behaving correctly #8

Closed
Joomv opened this issue Jul 6, 2016 · 3 comments
Closed

Email sharing doesn't seem to be behaving correctly #8

Joomv opened this issue Jul 6, 2016 · 3 comments

Comments

@Joomv
Copy link

Joomv commented Jul 6, 2016

When you click on the email share button and are using Outlook, you get the Title with + instead of spaces and a body call that stays in the subject line.

Changing line 25 of /plugins/content/joomlarrssb/tmpl/default.php
from
<a href="mailto:?subject=<?php echo urlencode($article->title); ?>body=<?php echo urlencode($itemURL); ?>">
to
<a href="mailto:?subject=<?php echo ($article->title); ?>&amp;body=<?php echo urlencode($itemURL); ?>">

Appears to fix this.

@mbabker
Copy link
Contributor

mbabker commented Jul 6, 2016

As long as the browsers all work OK without the subject URL encoded it's a good fix. I just don't want to break the browsers for the sake of good pre-filled subject lines in the email clients.

@Joomv
Copy link
Author

Joomv commented Jul 6, 2016

I'll try and do some further testing. Even if the subject line is left as urlencoded, we need the & before the body call.

@mbabker
Copy link
Contributor

mbabker commented Jul 6, 2016

Ampersand's added in now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants