Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Joomla.Commenting.FunctionComment.InvalidReturn errors with return type comments #228

Closed
photodude opened this issue Feb 10, 2018 · 0 comments · Fixed by #229
Closed

Joomla.Commenting.FunctionComment.InvalidReturn errors with return type comments #228

photodude opened this issue Feb 10, 2018 · 0 comments · Fixed by #229

Comments

@photodude
Copy link
Contributor

photodude commented Feb 10, 2018

The following error is happening in the Joomla.Commenting.FunctionComment.InvalidReturn sniff

Expected "array" but found "array  The lookup array. array({key name} => array(object, ...))" for function return type

Link to Example code comment triggering the error

https://github.com/joomla-framework/database/blob/master/src/DatabaseImporter.php#L181

Expected

no error

Actual

The comment for the return type is being included in the return type evaluation.

See also this Travis build
https://travis-ci.org/joomla-framework/database/jobs/339728069

@photodude photodude changed the title Joomla.Commenting.FunctionComment.InvalidReturn errors Joomla.Commenting.FunctionComment.InvalidReturn errors with return type comments Feb 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant