Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activity changes #426

Merged
merged 4 commits into from
Aug 18, 2014
Merged

Activity changes #426

merged 4 commits into from
Aug 18, 2014

Conversation

elkuku
Copy link
Contributor

@elkuku elkuku commented Aug 18, 2014

This will move the code for activity changes out to macros and add some new event types.

@b2z
Copy link
Member

b2z commented Aug 18, 2014

Great 👍 Tested -> merge in!

b2z added a commit that referenced this pull request Aug 18, 2014
@b2z b2z merged commit f18f939 into master Aug 18, 2014
@b2z b2z deleted the activity-changes branch August 18, 2014 19:04
@b2z
Copy link
Member

b2z commented Aug 18, 2014

Oh merged and forgot to ask - why you put activities.twig file under the /tracker/tpl/ ?

@elkuku
Copy link
Contributor Author

elkuku commented Aug 18, 2014

Well I thought it would be nice to have those "parts" under a separated sub directory.

What would be a better place?

@b2z
Copy link
Member

b2z commented Aug 19, 2014

Well I thought it would be nice to have those "parts" under a separated sub directory.

May be better name would be partials ? :) Or like in Symfony:

Just like templates, partials are files located in the templates/ directory, and they contain HTML code with embedded PHP. A partial file name always starts with an underscore (_), and that helps to distinguish partials from templates, since they are located in the same templates/ folders.

@elkuku
Copy link
Contributor Author

elkuku commented Aug 28, 2014

Sorry I missed that...
I think it's a good idea, "partials" sounds good, but as I understand, Symfony does not put them in a separate directory?
Could you move the files? 😉 also that fields.twig and tracker.filters.twig?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants