This repository has been archived by the owner on Nov 26, 2017. It is now read-only.
Cache Package: return JError #1079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -139,7 +141,7 @@ public static function getInstance($handler = null, $options = array()) | |||
| } | |||
| else | |||
| { | |||
| return JError::raiseWarning(500, JText::sprintf('JLIB_CACHE_ERROR_CACHE_STORAGE_LOAD', $handler)); | |||
| throw new RuntimeException('Cache Storage Class is not known.'); | |||
|
Thanks @chdemko - should be ready now. |
| @@ -114,7 +116,7 @@ public static function getInstance($handler = null, $options = array()) | |||
| $handler = $conf->get('cache_handler'); | |||
| if (empty($handler)) | |||
| { | |||
| return JError::raiseWarning(500, JText::_('JLIB_CACHE_ERROR_CACHE_HANDLER_NOT_SET')); | |||
| throw new UnexpectedValueException(sprintf('Unable to load Cache Storage: %s', $handler)); | |||
There was a problem hiding this comment.
UnexpectedValueException is great here but I don't think the message is accurate. This should only be thrown if no cache handler is set at all.
There was a problem hiding this comment.
Yup. You are right. Will change that.
|
@realityking - done, thanks |
realityking
added a commit
that referenced
this pull request
Apr 1, 2012
Cache Package: return JError
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.