This repository has been archived by the owner on Nov 26, 2017. It is now read-only.
JHtmlBatch tweak and unit tests #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
August 14, 2011 15:12
Test ResultsTotal Tests: 1282 |
added 5 commits
August 20, 2011 14:11
This reverts commit ad719ee.
Test ResultsTotal Tests: 1384 |
LouisLandry
added a commit
that referenced
this pull request
Aug 23, 2011
JHtmlBatch tweak and unit tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this pull request, the $published param is removed from JHtmlBatch's item method as it was implemented incorrectly (using published versus category.options expected filter.publish) and was inconsistent with other uses of category.options in that this was the only time a filter for publishing was implemented. Additionally, basic unit tests for the class' methods have been added.