Skip to content
This repository has been archived by the owner on Nov 26, 2017. It is now read-only.

Joomla CMS [#27630] Issue with replacePrefix -- valid only for SQLServer #719

Merged
merged 4 commits into from Jan 10, 2012

Conversation

sseshachala
Copy link
Contributor

@joomla-jenkins
Copy link

Unit testing complete. There were 0 failures and 0 errors from 1971 tests and 11146 assertions.
Checkstyle analysis reported 200 warnings and 1 errors.

@hooduku
Copy link
Contributor

hooduku commented Jan 7, 2012

Can any one please tell me where is that 1 warning and 1 error? I know the warnings should be less than 200 or 199.

@pasamio
Copy link
Contributor

pasamio commented Jan 7, 2012

Line 685 has white space at the end, not sure where the extra is warning is triggered from with a quick examination.

If you install phpcs via PEAR (http://pear.php.net/package/PHP_CodeSniffer/), executing the following in the root of the platform should tell you what is wrong:

phpcs --standard="build/phpcs/Joomla" libraries/joomla/database/database/sqlsrv.php

@joomla-jenkins
Copy link

Build triggered by changes to the head.

Unit testing complete. There were 0 failures and 0 errors from 1971 tests and 11146 assertions.
Checkstyle analysis reported 200 warnings and 1 errors.

@elkuku
Copy link
Contributor

elkuku commented Jan 7, 2012

The warning refers to a missing scope modifier for the function replacePrefix()
The white space in line 685 is still present ;)

@joomla-jenkins
Copy link

Build triggered by changes to the head.

Unit testing complete. There were 0 failures and 0 errors from 1971 tests and 11146 assertions.
Checkstyle analysis reported 199 warnings and 0 errors.

@sseshachala
Copy link
Contributor Author

Can this merged in to the platform please?

eddieajau added a commit that referenced this pull request Jan 10, 2012
This fixes the special case in sqlserver.
@eddieajau eddieajau merged commit 9bc51a4 into joomla:staging Jan 10, 2012
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants