-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add "fullscreen" for emacs-mac port? #34
Comments
(As I was writing up this report I realized that an easy workaround is just to change to 'lisp' mode in Customize and type |
Well, if Anyway, your problem is easily solved by manually setting the option in your init file: (setq writeroom-fullscreen-effect 'fullscreen) The type/value of a customisation option is only tested in the customisation buffer, (cond
((eq system-type 'gnu/linux)
(setq writeroom-fullscreen-effect 'fullboth))
((eq system-type 'darwin)
(setq writeroom-fullscreen-effect 'fullscreen))) As for adding this option to There would have to be a reliable way to distinguish the emacs-mac port from the official version, though. I'm not sure how to do that. |
|
This is arguably true, but I believe the reason that this is the case is that the " |
Yeah, that's what I was looking for. Since I don't have a Mac, I couldn't test it. The doc string of I did notice that
So, historical reasons. I suspected that might be the case. Anyway, I'll think about this a bit and let you know. |
I'm just going to throw out another vote for adding in "first class" support for |
I suspect a PR would increase the value of our votes :) |
@glyph: yea... I'm very very much a beginner at elisp... I expect something like: (defcustom writeroom-fullscreen-effect 'fullboth
"Effect applied when enabling fullscreen.
The value can be `fullboth', in which case fullscreen is
activated, or `maximized', in which case the relevant frame is
maximized but window decorations are still available."
:group 'writeroom
:type '(choice (const :tag "Fullscreen" fullboth)
(const :tag "Maximized" maximized)
(cond ((eq (window-system) 'mac) (const :tag "Mac Native Fullscreen" fullscreen)))
)
) But I'm not sure if this will just make |
Worse, it makes the customize option non-functional... Could you try the following: (defcustom writeroom-fullscreen-effect 'fullboth
"Effect applied when enabling fullscreen.
The value can be `fullboth', in which case fullscreen is
activated, or `maximized', in which case the relevant frame is
maximized but window decorations are still available."
:group 'writeroom
:type `(choice (const :tag "Fullscreen" fullboth)
(const :tag "Maximized" maximized)
,(cond ((eq (window-system) 'mac) (const :tag "Mac Native Fullscreen" fullscreen))))) This seems to work OK on my Linux box. |
Sorry for the (very) late reply. That didn't work. I only saw the first two options in the customize menu, not the conditional third one. |
How did you test it? Alternatively, paste the |
I pasted the How do I go about byte-compiling the file? or will just deleting the byte-compiled version work? |
But Emacs will load the byte-compiled file anyway, even if the non-byte-compiled version is newer. So in that case, the new definition wasn't used.
Open the file and do |
Ok, I recompiled the file, then reloaded. The drop-down menu doesn't work anymore: So it looks like that isn't working. |
Yes, I get that too, now. Not sure why it seemed to be working a month ago... I need some more time to figure out how to do this. In the mean time, you can use the following (defcustom writeroom-fullscreen-effect 'fullboth
"Effect applied when enabling fullscreen.
The value can be `fullboth', in which case fullscreen is
activated, or `maximized', in which case the relevant frame is
maximized but window decorations are still available."
:group 'writeroom
:type '(choice (const :tag "Fullscreen" fullboth)
(const :tag "Maximized" maximized)
(const :tag "Mac Native Fullscreen" fullscreen))) Or simply put: (setq writeroom-fullscreen-effect 'maximized) in your init file. |
Thanks, let me know if I can be of help. |
Hi, I'm not sure if anyone's still interested in this, but in case someone is: I created a branch Since I don't have a Mac available to me, I can't test it, which is why I haven't added it to master yet. I'd appreciate it if someone could try the |
https://bitbucket.org/mituharu/emacs-mac is an alternate Cocoa front-end to Emacs. Its window-system is
'mac
as opposed to the official'ns
.Its handling of fullscreen is slightly different than that of the official mac version as well. Whereas normal emacs has 2 behaviors,
fullboth
andmaximized
, wherefullboth
means "native fullscreen" andmaximized
means "resized as big as the screen", emacs-mac has three behaviors:fullboth
,fullscreen
, andmaximized
.fullboth
means "old-style fullscreen, just covering the entire normal desktop", andfullscreen
means "use native fullscreen support", similar to whatfullboth
means in the GNUns
frontend.It would be appreciated if you could add
fullscreen
to the list of options - or, better yet, detect this, so that my configuration would dofullboth
on linux andfullscreen
on emacs-mac.Thank you!
The text was updated successfully, but these errors were encountered: