Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The domain property collides with the same property on EventEmitter, causing a crash #2

Closed
AlCalzone opened this issue Aug 28, 2018 · 3 comments · Fixed by #3
Closed

The domain property collides with the same property on EventEmitter, causing a crash #2

AlCalzone opened this issue Aug 28, 2018 · 3 comments · Fixed by #3

Comments

@AlCalzone
Copy link
Contributor

sucks.js/index.js

Line 464 in 8d6062b

this.domain = domain;

This leads to ugly crashes when using this module, see https://forum.iobroker.net/viewtopic.php?p=172861#p172861
Also see this discussion for reference: nodejs/node-v0.x-archive#3922

Basically a class inheriting from EventEmitter must not have a domain property.
@AlCalzone AlCalzone mentioned this issue Aug 28, 2018
Merged
@AlCalzone
Copy link
Contributor Author

Proposed fix is at #3

@joostth
Copy link
Owner

joostth commented Aug 29, 2018

Thanks for posting the issue and providing the related fix in the pull request. Fix is included in v0.0.4 now available on npm.

@AlCalzone
Copy link
Contributor Author

Thanks for the quick reaction :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove collision of the domain property with EventEmitter
2 participants
@joostth @AlCalzone