Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License not packaged in pypi release #12

Closed
cshaley opened this issue Dec 19, 2017 · 6 comments
Closed

License not packaged in pypi release #12

cshaley opened this issue Dec 19, 2017 · 6 comments

Comments

@cshaley
Copy link
Contributor

cshaley commented Dec 19, 2017

The license states that it should be packaged in all distributions of the package, but it is not packaged in the pypi release. I only realized this because I am in the process of packaging bonarytree for conda forge.

@joowani
Copy link
Owner

joowani commented Dec 19, 2017

Right... if I remember correctly I was not packaging it correctly for earlier distributions. I will take a look tonight and see if removing the older distributions from pypi fixes the issue. Thanks!

@joowani
Copy link
Owner

joowani commented Dec 20, 2017

@cshaley I've removed all the older distributions from pypi. Let me know if that fixes things. What issue are you having exactly?

@synapticarbors
Copy link

I believe you need to add a MANIFEST.in to the package:

https://docs.python.org/2/distutils/sourcedist.html#specifying-the-files-to-distribute

@joowani
Copy link
Owner

joowani commented Dec 20, 2017

Thanks @synapticarbors. I will take a look and add it.

@cshaley
Copy link
Contributor Author

cshaley commented Dec 21, 2017

@joowani FYI, this is not a technical issue so much as a legal one. Best practice is to always package the license with the software. Not as big of a deal for something that uses the MIT license as it could be for a package with a custom/pay-for-play license.

@joowani
Copy link
Owner

joowani commented Dec 22, 2017

@cshaley I believe I've corrected the issue. Please let me know if you see any other problems. Thanks!

@joowani joowani closed this as completed Dec 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants