Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate escaping note contents. #2

Closed
Ahmad45123 opened this issue Jun 18, 2021 · 1 comment · Fixed by #4
Closed

Investigate escaping note contents. #2

Ahmad45123 opened this issue Jun 18, 2021 · 1 comment · Fixed by #4

Comments

@Ahmad45123
Copy link
Contributor

Currently, due to the way that I use to pass note contents into the webview, if the note contains a doublequote character, the contents of the note are cut off at that position and the rest of the contents are appended as html.

In the future, I may look into using an actual escaping library to handle all characters. Also we need to check if we need to "unescape" the notes in the webview side.

@xUser5000
Copy link

xUser5000 commented Jun 20, 2021

I faced a similar issue while working on my plugin, you can find some details here. I was able to solve it easily by using html-entities package, so you might want to check it out. It's a lightweight escaping library that you can customize according to your needs.
Good luck :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants