Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Null Safety? #5

Closed
FlavioBarros13 opened this issue Jan 15, 2022 · 5 comments
Closed

Null Safety? #5

FlavioBarros13 opened this issue Jan 15, 2022 · 5 comments

Comments

@FlavioBarros13
Copy link

FlavioBarros13 commented Jan 15, 2022

Hi mate great package , creating an app and thinking on integrating this any chance you working on a version with null safety?

Also would be great to be able to style the font colors and background

really great package well done!

@joranmulderij
Copy link
Owner

Thanks for reminding me. I had migrated, but forgot to publish to pub.dev. Version 0.0.8 should now be available and has null safety. It is now also possible to change the color of the font and lines. By wrapping it in a DecoratedBox or Container you should be able to change the background.

I'm glad you like the package.

@FlavioBarros13
Copy link
Author

FlavioBarros13 commented Jan 15, 2022

Thanks for reminding me. I had migrated, but forgot to publish to pub.dev. Version 0.0.8 should now be available and has null safety. It is now also possible to change the color of the font and lines. By wrapping it in a DecoratedBox or Container you should be able to change the background.

I'm glad you like the package.

Only one word to describe you brother....Genius! i've recommended the package to few people ...Well done!
looking forward to future features

@FlavioBarros13
Copy link
Author

FlavioBarros13 commented Jan 15, 2022

Hi mate..For a later update a major feature would be to also display the Guitar "FRAT NUMBER) on the starting point , for location detection if there's no black bar.... the chords show perfectly just some chords are on the upper side(upper octave) of the guitar arm

@joranmulderij
Copy link
Owner

This was one of the things that I removed from the chord.js package, because at the time I could not get it to work. I looked at it again, and found it to work now, but the alignment is a bit off on some of the sizes.

I am not going to publish to pub.dev immediately because I want to fix a few more things, but you can use the updated version of this package by putting this is dependency section of you pubspec.yaml file:

flutter_guitar_tabs:
    git:
      url: https://github.com/joranmulderij/flutter_guitar_tabs.git

By the way, thanks for the great feedback. If you have any more questions or suggestions, please tell me here.

@FlavioBarros13
Copy link
Author

This was one of the things that I removed from the chord.js package, because at the time I could not get it to work. I looked at it again, and found it to work now, but the alignment is a bit off on some of the sizes.

I am not going to publish to pub.dev immediately because I want to fix a few more things, but you can use the updated version of this package by putting this is dependency section of you pubspec.yaml file:

flutter_guitar_tabs:
    git:
      url: https://github.com/joranmulderij/flutter_guitar_tabs.git

By the way, thanks for the great feedback. If you have any more questions or suggestions, please tell me here.

Yeah been testing and messing with it and saw what you mean but it seems like you are quite close to solving the alignment issue ... also shared the package to a good number of people and they all loving it really great work

Attached some pic and small vid

WhatsApp Image 2022-01-15 at 19 44 27

WhatsApp.Video.2022-01-15.at.11.08.29.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants