Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swift 5 & Fix warnings #42

Closed
wants to merge 2 commits into from
Closed

Swift 5 & Fix warnings #42

wants to merge 2 commits into from

Conversation

emrcftci
Copy link

Description

  • This pull-request contains Swift version update & warning fixes

Motivation and Context

  • We'll have latest Swift version,

  • We'll solve language version related warnings

after this pull-request merge.

What kind of change does this PR introduce?

  • Bug fix (non-breaking change which fixes an issue)
  • File changes for improvement
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

@emrcftci
update(Swift): Update Swift version to 5
4abe85b
@emrcftci
fix(*): Fix Swift version related warnings
898b91d 
 - Remove deprecated `hashValue` computed property from CBUUIDPath

 - Add new `hash(into hasher:)` to CBUUIDPath

 - Add `@unknown default` case into CentralProxy's `Initialize Bluetooth requests` extension
@emrcftci
Copy link
Author

@jordanebelanger thanks for the project! I'm using the library in my projects but I want to avoid warnings.
PTAL 🚀

@jordanebelanger
Copy link
Owner

jordanebelanger commented May 25, 2020 •
edited

Hi @emrcftci

Thank you for the pull request, very appreciated. I haven't had that much interest on working on this library as I have been working mostly on swift server side stuff and other projects.

But, I still managed to update this library recently, sort of :)

Before I check about merging your PR, please check out this branch and test it out, it already includes your changes and more (it uses Swift 5.0's own Result type`)
https://github.com/jordanebelanger/SwiftyBluetooth/tree/2

If it works good for you, I will merge it to master and create a new release, my problem is testing which I haven't had much time to do.

@jordanebelanger
Copy link
Owner

@emrcftci I created a PR for that branch here #43

@emrcftci
Copy link
Author

Thanks for quick response. Of-course it is good for me 🚀 I'm going to close this pull-request.

@emrcftci emrcftci closed this May 25, 2020
@jordanebelanger
Copy link
Owner

@emrcftci Could you test out that branch by any chance? Would appreciate it a lot and help me merge the PR faster.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@emrcftci @jordanebelanger