Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hardcoded addresses #14

Closed
tionis opened this issue Jul 20, 2020 · 2 comments
Closed

Hardcoded addresses #14

tionis opened this issue Jul 20, 2020 · 2 comments

Comments

@tionis
Copy link

tionis commented Jul 20, 2020

A few locations in the frontend code contain hardcoded calls to the backend (eg. a post call to http://localhost:3333/users/me/avatar in the profile page template)
@tionis
Copy link
Author

tionis commented Jul 20, 2020 •
edited

On another note I would much appreciate a Contributing File specifying how best to contribute to the project.

JordanKnott added a commit that referenced this issue Jul 20, 2020
@JordanKnott
fix: replace hardcoded API url's with absolute paths
56a8753 
fixes issue #14
@JordanKnott
Copy link
Owner

Thanks for letting me know of some that I missed!

They have been updated as of commit 56a8753

A contributing file is a nice idea, I'll work on adding one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tionis @JordanKnott