Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SwiftUI Kit, on the tube! #22

Merged
merged 6 commits into from Jul 12, 2020
Merged

SwiftUI Kit, on the tube! #22

merged 6 commits into from Jul 12, 2020

Conversation

majouji
Copy link
Collaborator

@majouji majouji commented Jul 12, 2020 •
edited

Screen Shot 2020-07-11 at 22 40 25

Bam!

Also:

  • Removed extraneous asset catalogs (all targets share the same one now)
  • Changed a few conditional statements to exclude tvOS instead of including all 3 other platforms (little cleaner)

Known issues

  • Certain views don’t scroll, like FontsGrouping. May need an explicit ScrollView

@majouji majouji changed the title SwiftUI Kit, now in theaters! SwiftUI Kit, on the tube! Jul 12, 2020
@majouji majouji added the enhancement New feature or request label Jul 12, 2020
@Nef10
Copy link
Collaborator

Nef10 commented Jul 12, 2020

👍

@jordansinger
Copy link
Owner

Wonderful! We can address the known issues in a follow-up.

@jordansinger jordansinger merged commit 1da4381 into jordansinger:master Jul 12, 2020
@majouji majouji deleted the add-tvos-app branch July 12, 2020 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nef10 Nef10 Nef10 requested changes

@jordansinger jordansinger jordansinger approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@majouji @Nef10 @jordansinger