First draft of a macOS Version #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I am not sure if you plan to extend the app for macOS, but if so, I have a first draft. * Modified ControlsGroup and FontsGroup to use SectionView * Add target, create folder for target specific files * Move unsupported things behind os check (Haptic, ActionSheet) * Fix compilation errors (UIColor -> NSColor) * Add close button to sheet * Add scrollview and frames modifier to content is visible * Style SectionView because a macOS Section is without any styling Known problems: - [] Icon does not look like a Big Sur icon - [] Navigation Link button not working - [] When making view very thin some lables get cutoff, not sure why - [] Sheet needs styling
|
This is so great. Thanks for doing this, I had this in the plans. Let's merge and fix your known problems in a follow up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not sure if you plan to extend the app for macOS, but if so, I have
a first draft.
Known problems: