Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow removal of Vendor field for deb #778

Merged
merged 1 commit into from Oct 7, 2014
Merged

Allow removal of Vendor field for deb #778

merged 1 commit into from Oct 7, 2014

Conversation

nbrownus
Copy link
Contributor

@nbrownus nbrownus commented Oct 7, 2014

No description provided.

@jordansissel
Copy link
Owner

I would love tests for this, but am willing to merge without them.

The lintian tool doesn't seem to care that there's no Vendor field, which is nice. Here's my testing result:

% bin/fpm -s empty -t deb -n fizzle2 --vendor ""
Created package {:path=>"fizzle2_1.0_amd64.deb"}
⓿ oh-my(~/projects/fpm) pull/778
% lintian fizzle2_1.0_amd64.deb
E: fizzle2: changelog-file-missing-in-native-package
E: fizzle2: no-copyright-file
E: fizzle2: extended-description-is-empty
E: fizzle2: maintainer-name-missing <jls@oh-my>
E: fizzle2: maintainer-address-malformed <jls@oh-my>
W: fizzle2: unknown-section default
W: fizzle2: empty-binary-package
⓿ oh-my(~/projects/fpm) pull/778 !1!
% ar p fizzle2_1.0_amd64.deb control.tar.gz | tar -zxO ./control
Package: fizzle2
Version: 1.0
License: unknown
Architecture: amd64
Maintainer: <jls@oh-my>
Installed-Size: 0
Section: default
Priority: extra
Homepage: http://example.com/no-uri-given
Description: no description given

LGTM

jordansissel added a commit that referenced this pull request Oct 7, 2014
@jordansissel
Merge pull request #778 from nbrownus/master
7c9ba58 
Allow removal of Vendor field for deb

This can be done in the CLI by setting --vendor to an empty string. For example `--vendor ""`

The default behavior "Vendor: none" still remains.
@jordansissel jordansissel merged commit 7c9ba58 into jordansissel:master Oct 7, 2014
@jordansissel
Copy link
Owner

Thanks for helping mmake fpm more awesome!

prof-milki pushed a commit to prof-milki/xpm that referenced this pull request Dec 18, 2014
Merge pull request jordansissel#778 from nbrownus/master
a3daaa2 
Allow removal of Vendor field for deb

This can be done in the CLI by setting --vendor to an empty string. For example `--vendor ""`

The default behavior "Vendor: none" still remains.
prof-milki pushed a commit to prof-milki/xpm that referenced this pull request Dec 27, 2014
@jordansissel
Merge pull request jordansissel#778 from nbrownus/master
b502631 
Allow removal of Vendor field for deb

This can be done in the CLI by setting --vendor to an empty string. For example `--vendor ""`

The default behavior "Vendor: none" still remains.
jordansissel added a commit that referenced this pull request Apr 24, 2015
@jordansissel
Merge pull request #778 from nbrownus/master
9c59d5d 
Allow removal of Vendor field for deb

This can be done in the CLI by setting --vendor to an empty string. For example `--vendor ""`

The default behavior "Vendor: none" still remains.
jordansissel added a commit that referenced this pull request Jun 20, 2016
@jordansissel
Merge pull request #778 from nbrownus/master
8e551e5 
Allow removal of Vendor field for deb

This can be done in the CLI by setting --vendor to an empty string. For example `--vendor ""`

The default behavior "Vendor: none" still remains.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nbrownus @jordansissel