Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xdo_get_active_modifiers disrupts the conventions of the library #3

Closed
KoFish opened this issue May 22, 2012 · 2 comments
Closed

xdo_get_active_modifiers disrupts the conventions of the library #3

KoFish opened this issue May 22, 2012 · 2 comments

Comments

@KoFish
Copy link
Contributor

KoFish commented May 22, 2012

xdo_get_active_modifiers() returns a pointer to a struct instead of returning the values in arguments like all similar functions in the library does.
By changing this there would be no need for the xdo_active_mods_t struct either.

@jordansissel
Copy link
Owner

The current method definition is this:

int xdo_get_active_modifiers(const xdo_t *xdo, charcodemap_t **keys, int *nkeys) {

I think 7cf1eaa fixed this.

@jordansissel
Copy link
Owner

Closing since I think this was resolved in 7cf1eaa; reopen if you feel otherwise :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants