Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lollipop 馃嵀 #14

Merged
merged 6 commits into from Jun 13, 2022
Merged

Add lollipop 馃嵀 #14

merged 6 commits into from Jun 13, 2022

Conversation

atrinh0
Copy link
Collaborator

@atrinh0 atrinh0 commented Jun 13, 2022

Overview Detail
Simulator Screen Shot - iPhone 13 Pro Max - 2022-06-13 at 22 09 49 Simulator Screen Shot - iPhone 13 Pro Max - 2022-06-13 at 22 09 51
Simulator.Screen.Recording.-.iPhone.13.Pro.Max.-.2022-06-13.at.18.34.08.mp4

Code based on https://developer.apple.com/documentation/charts/visualizing_your_app_s_data

@jordibruin
Copy link
Owner

Can you add this as an optional setting ? Maybe it should even be a separate chart for clarity sake? 馃

@aaronpearce
Copy link
Contributor

aaronpearce commented Jun 13, 2022

I think it could be best to seperate this onto its own chart to make the first chart a simple example, then each major expansion could be a secondary chart.

Would keep the examples simple for developers so they can clearly see what causes what.

@atrinh0
Copy link
Collaborator Author

atrinh0 commented Jun 13, 2022

Can you add this as an optional setting ? Maybe it should even be a separate chart for clarity sake? 馃

Agreed

@jordibruin jordibruin merged commit cdd1617 into jordibruin:main Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants