New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changing dependency path doesn't invalidate node_modules #53
Comments
I think the current approach is that it creates the build cache key on the dependency's version number and package name. So if you bump the version number I suspect it will work, but I think we might want to hash on either the package contents, or the hash of mtimes on files within the package (which might be faster and sufficiently unique - as well as detecting when you modify a file). |
BTW I'm not modifying the package's content (they're symlinked and I wouldn't touch them anyway). I'm switching from a remote git url to a local one. What you said applies if I keep the same path but changes some content. In this case, the path's changed. |
Also, since we'll be finding little bugs/fixes in the build cache, maybe we should have an escape hatch called
|
Repro: change
"bs-platform": "esy-ocaml/bucklescript#esy"
to"bs-platform": "/path/to/local/bucklescript"
, then doesy install
while having an existing node_modules.The text was updated successfully, but these errors were encountered: