Discuss if simplification.

[jordwalke]

@robz

As I understand it, the flag --disable simplify_ifdecl was added to remove this following simplification:

-var y =
-  0 === x__0
-    ? ((caml_check_bound(a, 0)[1] = 42), 0)
-    : ((caml_check_bound(a, 0)[1] = 43), 0);
+
+if (0 === x__0) {
+  caml_check_bound(a, 0)[1] = 42;
+  var y = 0;
+} else {
+  caml_check_bound(a, 0)[1] = 43;
+  var y = 0;
+}

For posterity, what was the reason for this again?

(See commits a110716857 and a110716857^)

[robz]

Disabling declarations like "x = 3" within ternaries is required for Hack, since they removed "assignments-as-expressions" from the language. I believe I added the flag to retain jsoo's prior behavior with JS and potentially PHP.