Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dry Run? #452

Closed
nebb00 opened this issue Aug 31, 2023 · 9 comments
Closed

Dry Run? #452

nebb00 opened this issue Aug 31, 2023 · 9 comments

Comments

@nebb00
Copy link

nebb00 commented Aug 31, 2023

Would it be possible to have a dry run option, so we can see what affect the rule will have? What media it will delete and maybe the raw stats to prove it's correct

@jorenn92
Copy link
Owner

jorenn92 commented Sep 1, 2023

Hi, thanks for testing Maintainerr!

Maintainerr will not immediately delete your files. It will first add them to a temporary collection for x-duration (specified in parameter 'Media deleted after days')

You could always run your rules & check the collection. When you edit your rules, the collection will be removed and will only repopulate when the rule is run again. This is done because media might not be correct anymore due to changes you may have made.

The deletion will only take place when your media has been in the collection for longer than the specified amount of days.

You could simulate a dry run by executing rules & editing the rule after that to reset the collection.

The statistic page is interesting. This will indeed be useful.
However, it will take time to implement.
I'll go ahead and create a new task for this.

@nebb00
Copy link
Author

nebb00 commented Sep 1, 2023

My bad, i didn't understand before. While I have you, when you run your rule. How do you know the rule run has completed? I refreshed the collection a few times and the number increased.

Also my collection has lots of duplicates, even though only one item exists in plex. Any idea?

@jorenn92
Copy link
Owner

jorenn92 commented Sep 1, 2023

No problem! There's no indication on the UI currently. But you can tail the log, there should be a line when starting & one when it's done.

LOG [CollectionWorkerService] Handling collection '<Your collection name>'
LOG [CollectionWorkerService] Handling collection '<Your collection name>' done

There's indeed a UI issue where duplicate entries are shown on the collection screen. This doesn't impact your Plex collection or collection handling, there's only 1 record, but for some reason the UI renders the card twice.

@nebb00
Copy link
Author

nebb00 commented Sep 1, 2023

Thanks. Just did a rule for rule for movies last viewed before 365 days, it returns 593. But tautulli reckons it should be 739.

Really not sure why the difference

@jorenn92
Copy link
Owner

jorenn92 commented Sep 1, 2023

That rule should contain all movies that have not been viewed in the last year. However, if the movie wasn't viewed at all, it won't be selected.

It's debatable that unseen movies should be selected by the rule. I'm not really sure how most people interpret it and if i should alter its behavior.

To (hopefully) get what you want, you could try adding an 'OR' section with these 2 rules:

  • Plex - times viewed SMALLER than number 1
  • And Plex - date added BEFORE 365 days

@estahn
Copy link

estahn commented Dec 29, 2023

@jorenn92 I think this is not very clear to people. I was expecting some sort of dry-run. For rule creation some sort of preview would be very helpful, e.g. a list of movies/shows affected by the rule below.

@jorenn92
Copy link
Owner

jorenn92 commented Jan 2, 2024

A dry run doesn't really make sense because Maintainerr will only delete or unmonitor after the specified 'amount of days' has passed. Even if set to 1 day, you can freely edit and rerun the rule as many times as you like within that day. Any edit to the rules will reset the collection. Having a preview would, indeed, be beneficial.

@estahn
Copy link

estahn commented Jan 2, 2024

@jorenn92 Cheers. After testing things I agree, the dry-run doesn't make. It's a user-experience issue imo. Initially I was under the impression the rules will delete media instantly. A text box explaining this behaviour in the app would reduce confusion.

@jorenn92
Copy link
Owner

jorenn92 commented Jan 2, 2024

Yeah, i agree. The UX can use some work. Not sure when i'll have time to improve it though.. I'm being overwhelmed with activity on this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants