Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EuclideanDistance doesn't seem to work correctly #3

Closed
thobson opened this issue Apr 27, 2015 · 1 comment
Closed

EuclideanDistance doesn't seem to work correctly #3

thobson opened this issue Apr 27, 2015 · 1 comment

Comments

@thobson
Copy link

thobson commented Apr 27, 2015

The command line runner help is incorrect regarding EuclideanDistance:

if(radius == 0 && hashFamilyType.equalsIgnoreCase("l1")){
  measure = new CityBlockDistance(); 
  ...
} else if (radius == 0 && hashFamilyType.equalsIgnoreCase("l2")){
  measure = new CityBlockDistance();
  ...
}

CityBlockDistance is used for both L1 and L2
JorenSix added a commit that referenced this issue Apr 28, 2015
@JorenSix
Fixed l1 distance, it was incorrectly regarded as city block, now it …
c759f2b 
…is euclidean distance. (github issue #3, thobson)
@JorenSix
Copy link
Owner

Hi,

Thanks for the bug report, I have committed a fix (c759f2b).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JorenSix @thobson