-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Possible mistake in your implementation? #7
Comments
Hi, I find the official implement in tensorflow. The implementation is similar with this author's. |
|
Hello,
Regarding your stability issues, I will be merging a different approach to ensure stability in the initial iterations which may help you (if you're still interested). Thank you for your contributions. I will be closing this issue for now due to its age. If you still have any questions feel free to open a new one. |
In your implementation:
https://github.com/jorge-pessoa/pytorch-msssim/blob/master/pytorch_msssim/__init__.py
line 96:
output = torch.prod(pow1[:-1] * pow2[-1])
Should it be:
output = torch.prod(pow1[:-1]) * pow2[-1]
Otherwise the pow2 would be multiplied too many times?
Thanks!
The text was updated successfully, but these errors were encountered: