Added aws_endpoint_url cli option #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jorgebastida any chance you could review this please? |
|
Would be really great to merge this addition! |
|
+1 |
jorgebastida
requested changes
Jul 9, 2020
| @@ -55,6 +55,12 @@ def add_common_arguments(parser): | |||
| default=os.environ.get('AWS_REGION', None), | |||
| help="aws region") | |||
|
|
|||
| parser.add_argument("--aws-endpoint-url", | |||
There was a problem hiding this comment.
Making this argument read the environment like the other arguments would be ideal
|
It is such a long time that it is embarrassing, but if somebody manages to do that quick fix I would happily merge it. |
@jorgebastida added PR. Please check if it's enough. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be able to use awslogs with locally running instances of cloudwatch such as localstack, we need a way to overwrite the endpoint url.
This PR adds an
--aws-endpoint-urlcli flag to change the endpoint that is called by awslogs.