New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
setup.py rewritten to pbr, tests run by tox #50
Conversation
vlcinsky
commented
Jan 20, 2016
modified: .gitignore deleted: AUTHORS deleted: CHANGELOG deleted: MANIFEST.in new file: requirements-py26.txt new file: requirements.txt new file: setup.cfg modified: setup.py renamed: tests.py -> tests/test_it.py new file: tox.ini
modified: .travis.yml modified: requirements-py26.txt modified: requirements.txt modified: tox.ini
modified: .travis.yml
deleted: requirements-py26.txt modified: requirements.txt modified: setup.py new file: test-requirements.txt modified: tox.ini
modified: .travis.yml modified: test-requirements.txt modified: tox.ini
modified: tests/test_it.py modified: tox.ini
modified: README.rst new file: TESTING.rst
modified: tests/test_it.py
modified: awslogs/__init__.py new file: awslogs/_version.py modified: awslogs/bin.py modified: awslogs/core.py deleted: coverage.sh modified: setup.cfg modified: test-requirements.txt modified: tests/test_it.py new file: tests/test_versions.py
Assuming, this package (awslogs) is always available, if running. modified: awslogs/_version.py
Now it resolves the issue #37 |
One thing, which is bothering a bit with using pros and cons of using
|
To keep manually created AUTHORS and CHANGELOG in repo, they were renamed to AUTHORS.rst and CHANGELOG.rst. This shall prevent conflicts with `pbr` autogeneraged AUTHORS and CHANGELOG files. To update AUTHORS.rst and CHANGELOG.rst, build sdist and check, if autogenerated content of AUTHORS and CHANGELOG is proposing some authors or changes to add. flake8 tests added into tox.ini driven tests. Changes to be committed: new file: AUTHORS.rst new file: CHANGELOG.rst modified: COPYING modified: README.rst modified: awslogs/__init__.py modified: awslogs/bin.py modified: awslogs/core.py modified: awslogs/exceptions.py modified: test-requirements.txt modified: tests/test_it.py modified: tox.ini
Updated to merge without conflicts with current master.
my current PR is failing in the same way for python 3.* |
Hello @vlcinsky (first of all, sorry for the long delay) I've read quite a lot about pbr... and I'm not convinced. I might change my opinion in the future, but right now it is a bit too much magic to me. I understand In the other hand, I think the tox/travis changes were brilliant! I've create a new PR only including them and a few more changes. See #69 Hope you understand my view. |
@jorgebastida Thanks a lot for merging things in. I understand your decision to not accept |