Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.nvmrc should be searched by traversing the directory tree up #45

Closed
josalmi opened this issue Jun 5, 2017 · 3 comments
Closed

.nvmrc should be searched by traversing the directory tree up #45

josalmi opened this issue Jun 5, 2017 · 3 comments
Labels
enhancement New feature or request

Comments

@josalmi
Copy link

josalmi commented Jun 5, 2017

It would nice if .fnmrc file in parent directory would be applied to all child directories. This can be implemented by traversing the directory tree up while searching the .fnmrc file.

Example:
mkdir -p parent/children
cd parent
echo "6.9.3" > .fnmrc
node -v # Should be 6.9.3
cd children
node -v # Should also be 6.9.3

See NVM

@jorgebucaran jorgebucaran added the enhancement New feature or request label Jun 5, 2017
@jorgebucaran jorgebucaran changed the title Feature request: .fnmrc should be searched by traversing the directory tree up Feature request: .nvmrc should be searched by traversing the directory tree up Jan 9, 2019
@jorgebucaran
Copy link
Owner

Related #78.

@jorgebucaran jorgebucaran changed the title Feature request: .nvmrc should be searched by traversing the directory tree up .nvmrc should be searched by traversing the directory tree up Jan 9, 2019
@jorgebucaran
Copy link
Owner

@josalmi I finally did it. e2f6fb9 adds this behavior. It works by finding the nearest .nvmrc file, traversing the directory tree from the current working directory upwards.

@josalmi
Copy link
Author

josalmi commented Jan 25, 2019

Superb! Thanks for all the good work you are doing for the community.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants