Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'fisher update' hangs. #12

Closed
RafaelCosman opened this issue Jan 3, 2016 · 10 comments
Closed

'fisher update' hangs. #12

RafaelCosman opened this issue Jan 3, 2016 · 10 comments
Labels
bug Something isn't working outdated Forgotten lore

Comments

@RafaelCosman
Copy link

On C9 Ubuntu machine.

@ghost
Copy link

ghost commented Jan 3, 2016

Yes, this could be a problem in machines other than OS X and ubuntu/trusty64, the only two platforms I have tested this until now. The problem appears to be I am using find(1) in a non POSIX way...

The milestone I am working towards will fix this by removing the use of find(1) and adding a simple --cache to fisher to retrieve the relevant stuff from the cache. It's just a loop over $fisher_cache/* letting in paths that validate to test -d.

#11

@ghost ghost added the bug Something isn't working label Jan 3, 2016
@ghost ghost added this to the 0.2.0 milestone Jan 3, 2016
@ghost ghost self-assigned this Jan 3, 2016
@RafaelCosman
Copy link
Author

RafaelCosman commented Jan 3, 2016

Thanks for working on this, @jorgebucaran.

@simnalamburt
Copy link
Contributor

👍

@ghost
Copy link

ghost commented Jan 4, 2016

@RafaelCosman @simnalamburt

Guys, I was mistaken and replied to this message shortly after another user had reported a similar issue and claimed it had to do with find(1). This in fact, has nothing to do with that, (probably), and it's just the default behavior of update.

Fisherman has strong ties to the UNIX philosophy, at least it says so in the manual 😄 and one of the things that are common across commands is that streams are prioritized.

So, fisher update will hang because is waiting for input. This allows cool things like:

fisher --cache | fisher udpate

or

fisher update < bundle

@ghost ghost removed this from the 0.2.0 milestone Jan 4, 2016
@rif
Copy link

rif commented Jan 6, 2016

So what is the recommend way to list/update all installed plugins?

@ghost
Copy link

ghost commented Jan 6, 2016

Hey @RafaelCosman

fisher update plugin1 plugin2 ...

fisher update -h
usage: fisher update [<name or url> ...] [--me] [--quiet] [--help]

       -m --me  Update Fisherman
    -q --quiet  Enable quiet mode
     -h --help  Show usage help

If you want to update all the plugins you could try:

fisher --cache | fisher update

asciicast

@simnalamburt
Copy link
Contributor

I think making fisher update to update all plugins is the best default. Most package managers like npm, gem, etc update all installed plugin when they executed with ~~ update and I think most users are used to it.

Yes fisher --cache | fisher update fits very well with UNIX philosophy but fisher update is also good default, and I think both can coexist with isatty(3) just like as the python binary does.

How do you think?

@ghost
Copy link

ghost commented Jan 7, 2016

@simnalamburt Alright. 👍

Can you create an issue indicating this feature request and I will work on it. After thinking about this in my end, I came to the conclusion you are right.

We can always do this:

fisher --cache | fisher update -

@ghost
Copy link

ghost commented Jan 8, 2016

fisher update

To update Fisherman.

fisher update -

To read from STDIN.

fisher update a url local_path ...

To update all that stuff.

@ghost ghost closed this as completed Jan 8, 2016
@simnalamburt
Copy link
Contributor

Perfect

@ghost ghost removed their assignment Sep 19, 2016
@jorgebucaran jorgebucaran added the outdated Forgotten lore label Sep 12, 2018
Repository owner locked as resolved and limited conversation to collaborators Sep 12, 2018
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working outdated Forgotten lore
Projects
None yet
Development

No branches or pull requests

4 participants