Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-44053 Make countByO_O_P method consistent, so that it generates its SQL properly when default preferences have to be excluded #314

Closed
wants to merge 10 commits into from
Closed

LPS-44053 Make countByO_O_P method consistent, so that it generates its SQL properly when default preferences have to be excluded #314

wants to merge 10 commits into from

Conversation

mdelapenya
Copy link

cc/ @cgoncas

cgoncas and others added 10 commits February 5, 2014 16:01
@cgoncas @mdelapenya
LPS-44013 New utility class has been created for the PortletPreferenc…
ccbcd73 
…es tests.
@cgoncas @mdelapenya
LPS-44013 A new method addLayout has been created to create a layout …
5148b70 
…by a specific group.
@cgoncas @mdelapenya
LPS-44013 A new test class has been created to test the PortalPrefere…
631592a 
…ncesLocalService. The test testGetPreferencesCountByOwnerPortletExcludeDefault fails because there are a bug in the code.
@mdelapenya
LPS-44013 SF
09290ef
@mdelapenya
LPS-44013 Support modifying strict parameters in MockPortletPreferenc…
9ce5acc 
…es service
@mdelapenya
LPS-44013 Extract mock service creation to a method
5d4fe86
@mdelapenya
LPS-44013 Add a test checking the opposite behaviour of tck.url property
716949e
@mdelapenya
LPS-44013 Set portletPreferencesLS to mock service
9b7a28a
@mdelapenya
LPS-44013 Rename variable to represent a mock portletId
f8522d8
@cgoncas @mdelapenya
LPS-44053 Make countByO_O_P method consistent, so that it generates i…
cd95f3c 
…ts SQL properly when default preferences have to be excluded
@mdelapenya mdelapenya restored the pull-186 branch February 5, 2014 15:27
@mdelapenya mdelapenya mentioned this pull request Feb 5, 2014
Closed
@mdelapenya
Copy link
Author

I've added mofifications you suggested

@JorgeFerrer
Copy link
Owner

Just started reviewing :)

:octocat: Sent from GH.

@JorgeFerrer
Copy link
Owner

Pull request submitted to brianchandotcom#16489.

:octocat: Sent from GH.

@JorgeFerrer JorgeFerrer closed this Feb 6, 2014
@mdelapenya mdelapenya deleted the pull-186 branch March 26, 2014 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@mdelapenya @JorgeFerrer @cgoncas