Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor sound generation and just include the player #10

Closed
jorgegv opened this issue Dec 18, 2020 · 2 comments
Closed

Refactor sound generation and just include the player #10

jorgegv opened this issue Dec 18, 2020 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@jorgegv
Copy link
Owner

jorgegv commented Dec 18, 2020

Refactor sound generation and just include the player. Include sounds
in .gdata files, so that only used sounds are generated and included in
the final game

Idea: define a sound bank first, then assign sounds from the bank somewhere else

@jorgegv jorgegv added the enhancement New feature or request label Dec 18, 2020
@jorgegv jorgegv self-assigned this Dec 18, 2020
@jorgegv
Copy link
Owner Author

jorgegv commented Feb 15, 2021

Most probably this can be handled by...removing it and instead using the z88dk provided sound libraries and sound banks

@jorgegv
Copy link
Owner Author

jorgegv commented Feb 15, 2021

The beep_fx routine which was included (and ripped from La Churrera) has been included in stock Z88DK in the 1-bit sound library as bit_beepfx. The player is just 148 bytes, and I've had some trouble using the library directly, because tit was being located into contended memory.

So, as the fx definitions are compatible with the library ones, and those are already setup with #defines and labels, ready to be used from C, I have just kept the beeper.asm (which I can kick into high memory), adapted it to work with the same parameters as the library routine, and removed all sounds from the sound bank.

Sounds will come from the sound library if used.

@jorgegv jorgegv closed this as completed Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant