Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Bring editor to focus when "dispatching path" #3

Open
rlabrecque opened this issue May 20, 2022 · 3 comments
Open

Comments

@rlabrecque
Copy link

Upon clicking a Hermes link, it may be nice to also bring the editor into focus if it's not already.

Clicking an http/s link brings my browser (Firefox) into focus, so this would feel natural I'd think.

Using Hermes: d8cbc91
Unreal: UE5.1
OS: Windows 10

@jorgenpt
Copy link
Owner

Currently it tries to do that, though this is done in the content endpoint specifically, and not for arbitrary URLs. That should probably be hoisted up a level (though there are potentially multiple windows that could be active) to happen for all URLs. (https://github.com/jorgenpt/Hermes/blob/2b99cb8/HermesCore/Source/HermesContentEndpoint/Private/HermesContentEndpoint.cpp#L142)

Are you not seeing that happen for the default content URLs? It's possible it's not working as intended.

@jorgenpt
Copy link
Owner

jorgenpt commented May 20, 2022

This might also be a bug in hermes_urls, in that we might need to add a call to AllowSetForegroundWindow to make HACK_ForceToFront work reliably.

@jorgenpt
Copy link
Owner

The new hermes_urls version has that call, but it's unclear as to why it's not bringing Unreal to focus -- it does for me. I'm not able to reproduce it not getting focus.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants