-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds mssql driver #59
base: main
Are you sure you want to change the base?
Conversation
Whopsie, forgot a big todo. Give me a moment. |
Thank you for the PR. I'll check and test it a bit a come back with suggestion/merging. |
I will check on this as soon as I have time. |
Oh and I did not mention this yet: it's a great project you created here. Props for that. :) |
I'm on M1 also, i just created a docker instance.
Thank you very much, i love this project, i use it daily. I know it is not the best code (first go project), and it have bugs, but with the help of the community we can make this awesome. Thanks for your time making this PR. |
Okay I found the issue. I specified the database directly in my connection string, therefore the DB-Server knew where to run my queries. I added some todos, since I did not want to refactor a lot of your code without a review first. And it has nothing to do with the matter of this PR. Check it out, and please give me again feedback. I want to see this project moving forward, so I also can integrated in my day-to-day tools set. |
So the problem is, that even though the drivers interface specifies the GetTableColumns with the parameters database and table, the database is empty, whereas the table is of format database.table. I would love to make this a separate PR. For now I will always check if the table param contains a database and if so overwrite database param, I guess. If you have a way for private communication let me know. I would love to here what you say on the interface change. I am sure there is a reason that the database is encoded in the table param, that I just dont know about. |
…gnKeys, GetIndexes. Fixes GetTableColumns in mssql driver. adds logger
When i try to filter a table, the following error happens: ![]()
I agree that should be refactored |
Summary
Adds a mssql driver in drivers
Changes
Related Issues
Fixes #12