Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration tests not working on the correct python virtualenv in vagrant #15

Closed
jorisroovers opened this issue Aug 4, 2016 · 0 comments
Labels
bug User-facing bugs

Comments

@jorisroovers
Copy link
Owner

jorisroovers commented Aug 4, 2016

When running the integration tests in the vagrant box (./run_tests_.sh -i) from a virtualenv (e.g. .venv27 on the vagrant box), the qa/test_hooks.py file will actually use the system-wide python installation. This is because the commit-msg hook shell script contains python -m gitlint.cli which won't use the currently active virtualenv.

See

cat "$1" | python -m gitlint.cli

This should be fixed because now developers have the impression that the integration tests for the gitlint hooks are ran against all the python virtualenvs, while in reality they're only ran against the systemwide python installation.

@jorisroovers jorisroovers added the bug User-facing bugs label Aug 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug User-facing bugs
Projects
None yet
Development

No branches or pull requests

1 participant