Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃И馃敡 Switch to using pypa/build in CI #463

Merged

Conversation

webknjaz
Copy link
Contributor

@webknjaz webknjaz commented Mar 9, 2023

This patch switches the CI/CD workflows to use the PyPA-endorsed PEP 517 build front-end called build. It is called without --sdist and --wheel CLI options, in which case build creates an sdist from the Git checkout but the following wheel build is made from that sdist tarball as opposed to using the Git checkout.

This has a side effect of smoke-testing that it's possible to build wheels from the published sdists. And this is the flow that pip install follows when it's requested to install from an sdist.

Ref: #460 (comment)

This patch switches the CI/CD workflows to use the PyPA-endorsed
PEP 517 build front-end called `build`. It is called without
`--sdist` and `--wheel` CLI options, in which case `build` creates
an sdist from the Git checkout but the following wheel build is made
from that sdist tarball as opposed to using the Git checkout.

This has a side effect of smoke-testing that it's possible to build
wheels from the published sdists. And this is the flow that
`pip install` follows when it's requested to install from an sdist.

Ref: jorisroovers#460 (comment)
@coveralls
Copy link

Coverage Status

Coverage: 99.662%. Remained the same when pulling 8207faa on webknjaz:maintenance/pypa-build-in-ci into 1f8a16b on jorisroovers:main.

@jorisroovers
Copy link
Owner

Thanks!

@jorisroovers jorisroovers merged commit 61a69ea into jorisroovers:main Mar 10, 2023
jorisroovers added a commit that referenced this pull request Mar 10, 2023
- Fix issue that prevented homebrew packages from being built (#460)
- Switch to using pypa/build in CI (#463)

Full Release details in CHANGELOG.md.
@jorisroovers jorisroovers mentioned this pull request Mar 10, 2023
jorisroovers added a commit that referenced this pull request Mar 10, 2023
- Fix issue that prevented homebrew packages from being built (#460)
- Switch to using pypa/build in CI (#463)

Full Release details in CHANGELOG.md.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants