Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail on the presence of fixups #83

Closed
dmtucker opened this issue Feb 22, 2019 · 1 comment
Closed

Fail on the presence of fixups #83

dmtucker opened this issue Feb 22, 2019 · 1 comment

Comments

@dmtucker
Copy link

We use fixup/squash commits during PRs, and they should always be squashed before merging. It's not uncommon to forget to do that and end up with fixups in the permanent history, though. Setting general.ignore-fixup-commits=false is not adequate for preventing the presence of fixups before merge because gitlint will still pass if they meet all commit criteria. I would like to request a way to have gitlint fail if even well-formed fixup/squash/other WIP/TODO commits are detected (if there isn't already a way to do that).

@dmtucker
Copy link
Author

Ah, this is doable with

-c general.ignore-fixup-commits=false -c general.ignore-squash-commits=false -c title-must-not-contain-word.words='fixup,squash'

Interestingly, this does not seem to work:

-c general.ignore-fixup-commits=false -c general.ignore-squash-commits=false -c title-must-not-contain-word.words='fixup!,squash!'
  • Note the !s.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant