Increase the usage of augmented assignment statements

[elfring]

👀 Some source code analysis tools can help to find opportunities for improving software components.
💭 I propose to increase the usage of augmented assignment statements accordingly.

Would you like to integrate anything from a transformation result which can be generated by a command like the following?
(:point_right: Please check also for questionable change suggestions because of an evolving search pattern.)

[Markus_Elfring@fedora lokal]$ perl -p -i.orig -0777 -e 's/^(?<indentation>\s+)(?<target>\S+)\s*=\s*\k<target>[ \t]*(?<operator>[+\-%&|^@]|\*\*?|\/\/?|<<|>>)/$+{indentation}$+{target} $+{operator}=/gm' $(find ~/Projekte/borb/lokal -name '*.py')

[jorisschellekens]

Hi,

We have a great guide on how to submit an issue to us.
You can check it out here.

If your request does not comply with our guidelines, it will be deleted after 1 week.

Kind regards,
Joris Schellekens

[elfring]

💭 I would appreciate if the change support can be clarified a bit more for the shown transformation pattern (before it will eventually be converted to another pull/merge request).

[jorisschellekens]

I'll try to summarize:

1. Clone the repo (make sure you're up to date)
2. Implement your changes (in your case running the command line statement you've provided)
3. Check whether everything still works (run the test suite in the repo)
4. Run black borb to ensure the code style is consistent everywhere
5. Run mypy to ensure you did not add any type-warnings
6. Submit a pull request with your version of the repository
7. Sign the contributor agreement

Kind regards,
Joris Schellekens

[elfring]

It seems that you prefer further clarification according to corresponding pull requests (instead of previous change support indications). 🤔

[jorisschellekens]

I honestly don't know what you mean by your previous comment.
Keep in mind that English is not my first language.

What do you mean by "change support indications" ?

[elfring]

💭 I would find an indication for the understanding of the presented change pattern nicer (instead of the chosen generic response).

[jorisschellekens]

I can assure you every reply is typed, letter by letter (not copy/pasted) by me, the author of the library.
And although I do enjoy people's feedback on my library,
I have to set some rules to make sure everything goes smoothly.

[jorisschellekens]

Hi,

It's been a week since you opened this ticket. Despite my clear guidelines on what I expect in a bug report or feature request, this ticket has not met those standards.

You have also stopped answering.

I am going to close this ticket due to inactivity.

Kind regards,
Joris Schellekens