Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 2 Compatability? #40

Closed
kastman opened this issue Jun 24, 2016 · 1 comment
Closed

Python 2 Compatability? #40

kastman opened this issue Jun 24, 2016 · 1 comment

Comments

@kastman
Copy link
Contributor

kastman commented Jun 24, 2016

Hi Josh,

Thanks for sharing biocode. Any interest in accepting pull requests for single files (I'm just looking at fastq/randomly_subsample_fastq.py) that would cheaply add py2 compatibility (change the hashbang, cast to float for future division)? On the bright side it would increase usability, but I understand if you only want to test against py3. Thanks for putting this out there,

@jorvis
Copy link
Owner

jorvis commented Jun 26, 2016

Yes, definitely. If you can assert that you've tested them for python2 without breaking python3 use, I'd happily accept them. Feel free to send any pull requests you like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants