Skip to content
This repository has been archived by the owner on Jun 11, 2022. It is now read-only.

Editor freezes when using atom-blame in large files #31

Open
MoritzKn opened this issue Feb 21, 2017 · 10 comments
Open

Editor freezes when using atom-blame in large files #31

MoritzKn opened this issue Feb 21, 2017 · 10 comments
Labels

Comments

@MoritzKn
Copy link

MoritzKn commented Feb 21, 2017

When using atom-blame on large files (1500+ lines) in a git repository with a long history (2500+ commits) my Editor freezes and I have to kill the process. In smaller files it sometimes takes one or two seconds to load the blame.
I am using 1.13.0 and atom-blame 0.10.2 on GNU/Linux.
Let me know if you need more information.

@josa42 josa42 added the bug label May 11, 2017
@jinglesthula
Copy link

I've been able to reproduce this as well. I see it in files with a similar number of lines and number of commits.

I wonder if whatever's being done could be done either off the main thread or done incrementally (perhaps with a progress indicator). If some lines' blame info has been displayed, and other lines' blame info is still being gathered or rendered, it may be good to color those lines differently in the gutter so the user knows the blame info is pending, and isn't led to believe a line that hasn't been picked up yet is simply part of the same commit as the most recently rendered line of blame info. This could easily be done by using the 10px or so of color applied on the left side of the gutter. For lines that are pending, the color could be diagonal striped, similar to bootstrap's progress bars.

@josa42
Copy link
Owner

josa42 commented Jun 1, 2017

Could you try if the next branch works for you? I use the git-blame package, which uses streaming. At least for me this works with bigger files.

@MoritzKn
Copy link
Author

MoritzKn commented Jun 2, 2017

Ok I tried out the next branch. The issue is not gone but it changed. Now the editor stays responsive while the gutter is still empty for about 3 seconds, then the editor freezes for about 10 seconds before finally showing the result. I tested with the file src/text-editor.coffee (3767 lines) from the atom repo (31728 commits).

@josa42
Copy link
Owner

josa42 commented Jun 2, 2017

@MoritzKn Do you have an open source project where I can reproduce that?

@MoritzKn
Copy link
Author

MoritzKn commented Jun 3, 2017

@josa42 As I said, I could reproduce this in the atom editor git repository with the file src/text-editor.coffee.

@josa42
Copy link
Owner

josa42 commented Jun 3, 2017

Oops 🙃. Thanks

@tianbis
Copy link

tianbis commented Dec 26, 2017

Any news about this? I'm experiencing the same issue.

@dorian-marchal
Copy link

This issue still exists.

@ninedev-i
Copy link

The same problem

@senyaak
Copy link

senyaak commented Mar 15, 2019

+1 Large json + 4k lines - freeze and crash

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

7 participants