Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor index.d.ts #2913

Merged
merged 7 commits into from
Mar 14, 2023
Merged

Refactor index.d.ts #2913

merged 7 commits into from
Mar 14, 2023

Conversation

brunoSnoww
Copy link
Contributor

@brunoSnoww brunoSnoww commented Mar 11, 2023 •
edited
Loading

This PR refactors some types in the index.d.ts file to use generics to achieve the same type restrictions but with less lines of code.

@brunoSnoww brunoSnoww marked this pull request as ready for review March 11, 2023 21:26
@brunoSnoww brunoSnoww marked this pull request as draft March 11, 2023 21:50
@brunoSnoww brunoSnoww marked this pull request as ready for review March 12, 2023 10:15
josdejong
josdejong requested changes Mar 13, 2023
View reviewed changes
Copy link
Owner

@josdejong josdejong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that is a huge improvement! Much better readable, thanks Bruno 😎

I made a few inline comments, can you have a look at those?

types/index.d.ts Outdated Show resolved Hide resolved
types/index.d.ts Outdated Show resolved Hide resolved
types/index.d.ts Show resolved Hide resolved
@josdejong josdejong merged commit 2a050cd into josdejong:develop Mar 14, 2023
@josdejong
Copy link
Owner

The refactor is published now in v11.7.0. Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josdejong josdejong josdejong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@brunoSnoww @josdejong