New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: #2990 DenseMatrix can mutate input arrays #2991
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some concerns about whether this is ready for merging, see the review comments, thanks.
…put' into fix/2990_densematrix_mutating_input
Everything looked good to me at this point, so I synced this PR with develop and the tests are running. As far as I am concerned, you could consider merging presuming the tests pass. |
Published now in |
Fixes #2990
DenseMatrix
being able to mutate the original input arrayassign
to make it more clear that it is temporarily wrapping an Array into a Matrix