Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added subtractScalar #3081

Merged
merged 5 commits into from
Oct 25, 2023
Merged

added subtractScalar #3081

merged 5 commits into from
Oct 25, 2023

Conversation

vrushaket
Copy link
Contributor

Hello @josdejong,
I have added the implementation for subtractScalar, please have a look.
This will help solve PR #2643

Copy link
Owner

@josdejong josdejong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @vrushaket! This looks good.

As a bonus, it maybe interesting to look through the code base for places where subtract is used but only for scalars. If so, we can replace it with subtractScalar which should be good for performance.

@vrushaket
Copy link
Contributor Author

vrushaket commented Oct 18, 2023

Thanks a lot @vrushaket! This looks good.

As a bonus, it maybe interesting to look through the code base for places where subtract is used but only for scalars. If so, we can replace it with subtractScalar which should be good for performance.

Absolutely. I was also thinking of the same. I will make necessary changes, to make it happen.

@vrushaket
Copy link
Contributor Author

@josdejong , all changes have been committed.
Please check.

@josdejong
Copy link
Owner

Thanks for the updates @vrushaket , this looks good! I'm sure we gained some performance improvements with this, though I'm not sure how significant it is.

@josdejong josdejong merged commit 8f8e506 into josdejong:develop Oct 25, 2023
8 checks passed
@josdejong
Copy link
Owner

Published now in v11.12.0, thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants