-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added subtractScalar #3081
added subtractScalar #3081
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @vrushaket! This looks good.
As a bonus, it maybe interesting to look through the code base for places where subtract
is used but only for scalars. If so, we can replace it with subtractScalar
which should be good for performance.
Absolutely. I was also thinking of the same. I will make necessary changes, to make it happen. |
@josdejong , all changes have been committed. |
Thanks for the updates @vrushaket , this looks good! I'm sure we gained some performance improvements with this, though I'm not sure how significant it is. |
Published now in |
Hello @josdejong,
I have added the implementation for subtractScalar, please have a look.
This will help solve PR #2643